Support building on mybinder.org to ease testing #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you make it a .binder folder, and add an inline comment in the requirements.txt file that this is to help us start the repo at mybinder.org for UI testing purposes? |
consideRatio
force-pushed
the
binder-build
branch
from
0208c37
to
276b957
Compare
|
I implemented the changes I suggested and force pushed a rebase. Instead of @manics wdyt about this PR as it is now? I noted that I could get nbgitpuller started without having .binder/requirements.txt, which made sense to me as i believe repo2docker will detect setup.py etc and install this directly. |
consideRatio
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment if you want to test a PR that affects the UI you need to clone the PR and install it locally. In many cases testing on mybinder.org is good enough, the main exceptions are some interactions which are dependent on whether jupyter-notebook or jupyter-server is used.